Payload validation refactoring for processes, roles, routes, and service bindings #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
force-pushed
the
issues/1996-payload-validation
branch
from
e99b618
to
6f569e4
Compare
kieron-dev
changed the title
kieron-dev
force-pushed
the
issues/1996-payload-validation
branch
from
965ac11
to
f3c79ea
Compare
kieron-dev
changed the title
danail-branekov
approved these changes
Jun 27, 2023
Co-authored-by: Danail Branekov <[email protected]>
We also migrated all role validation to jellydator Issue: #1996 Co-authored-by: Danail Branekov <[email protected]>
This includes: - switching list routes to use the requestValidator to parse URL params - changing from go-playground to jellydator validation Issue: #1996
And migrate from go-playground to jellydator validation.
E.g. AppCreate payload has relationships.space.data.guid. If we use pointers all the way down, we get the correct error message if the json only contains some of the path. So providing `relationships.space` would error with `data` being required. Issue: #1996 Co-authored-by: Kieron Browne <[email protected]>
danail-branekov
force-pushed
the
issues/1996-payload-validation
branch
from
3c8e152
to
9dec9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1996
What is this change about?
/v3/processesDoes this PR introduce a breaking change?
No
Acceptance Steps
Tag your pair, your PM, and/or team
@danail-branekov